Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: create TOTP #322

Merged
merged 3 commits into from
Sep 5, 2024
Merged

feat: create TOTP #322

merged 3 commits into from
Sep 5, 2024

Conversation

NicolasLopes7
Copy link
Contributor

@NicolasLopes7 NicolasLopes7 commented Sep 5, 2024 •
edited
Loading

This PR implements a new method under the user's client to create TOTP

@NicolasLopes7 NicolasLopes7 requested a review from a team as a code owner September 5, 2024 15:10
@NicolasLopes7 NicolasLopes7 force-pushed the nicolas/dash-332-dapi-ability-to-add-2fa-method branch from 80b1acb to a050c6a Compare September 5, 2024 15:13
LauraBeatris
LauraBeatris reviewed Sep 5, 2024
View reviewed changes
totp.go Outdated Show resolved Hide resolved
LauraBeatris
LauraBeatris reviewed Sep 5, 2024
View reviewed changes
user/api.go Outdated Show resolved Hide resolved
LauraBeatris
LauraBeatris approved these changes Sep 5, 2024
View reviewed changes
Copy link
Member

@LauraBeatris LauraBeatris left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I just left a question, don't want to block the release here.

@NicolasLopes7 NicolasLopes7 force-pushed the nicolas/dash-332-dapi-ability-to-add-2fa-method branch from 5b572a5 to 5548cc3 Compare September 5, 2024 16:30
@NicolasLopes7 NicolasLopes7 merged commit daecde7 into v2 Sep 5, 2024
5 checks passed
@NicolasLopes7 NicolasLopes7 deleted the nicolas/dash-332-dapi-ability-to-add-2fa-method branch September 5, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LauraBeatris LauraBeatris LauraBeatris approved these changes

@mzhong9723 mzhong9723 mzhong9723 approved these changes

@thiskevinwang thiskevinwang Awaiting requested review from thiskevinwang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NicolasLopes7 @mzhong9723 @LauraBeatris