-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add create session token given a template slug endpoint #238
feat: Add create session token given a template slug endpoint #238
Conversation
soulcodex
commented
Feb 9, 2024
- Add clerk backend api endpoint implementation to create a session token given a jwt template slug
c57e0bc
to
c0b3b0e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution @soulcodex!! 😍
Overall looks great to me. I've left some comments regarding variable naming and an alternative assertion for the tests.
Please remove the integration test, it depends on the instance setup and cannot be trusted. It's not your fault, but ours. 😄
Out of curiosity, what led you to add support in the SDK for this endpoint? Do you intend to use it?
c0b3b0e
to
0e4a2fc
Compare
0e4a2fc
to
327774e
Compare
The changes requested has been made 😉 The main motivation for this proposal is because I'm trying to run on my project an acceptance / E2E tests suite in order to verify that my securized endpoints works as expected. Unfortunately to be able to run E2E tests on my backend I need to accomplish several steps, such as:
However feel free to request any other change but this is basically my adventure / motivation about this PR 😅 |
Thanks for providing such detailed information! I just wanted to get a sense of real-world usage patterns. Thank you for your contribution! |