Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update README to include Client constructor options #195

Conversation

georgepsarakis
Copy link
Contributor

@georgepsarakis georgepsarakis commented Dec 8, 2023

Closes #194

Type of change

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • 🌟 New feature (non-breaking change which adds functionality)
  • 🔨 Breaking change (fix or feature that would cause existing functionality)
  • 📖 Docs change / refactoring / dependency upgrade to change)

Description

  • Add documentation and example for injecting a custom *http.Client instance for use by the SDK methods.
image

Related Issue (optional)

Closes #194

@georgepsarakis georgepsarakis requested a review from a team as a code owner December 8, 2023 09:58
Copy link
Member

@chanioxaris chanioxaris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@georgepsarakis georgepsarakis merged commit 1dc9d2a into main Dec 11, 2023
1 check passed
@georgepsarakis georgepsarakis deleted the georgepsarakis-issue-194-document-client-constructor-options branch December 11, 2023 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Retries in http client
2 participants