feat: Add organization roles endpoints #173
Conversation
mzhong9723
force-pushed
the
core-385-org-role-endpoints
branch
2 times, most recently
from
63a7ef1 to
ea23bde
Compare
clerk/clerk.go
Outdated
| @@ -309,6 +313,10 @@ func (c *client) Organizations() *OrganizationsService { | |||
| return c.organizations | |||
| } | |||
|
|
|||
| func (c *client) OrganizationRoles() *OrganizationRolesService { | |||
There was a problem hiding this comment.
I am thinking that we probably need to differentiate between organization roles on the instance level and on the organization level. If in the future we are looking to add endpoints dedicated to the organization endpoints (e.g. /v1/organizations/:id/roles) we will have a name conflict here
A solution to that is to move the roles methods on the instance service and do something like that
clerk.Instances().CreateOrganizationRole()
....Let's discuss offline as well!
There was a problem hiding this comment.
I would also expect these methods to go into different services.
clerk.Instances().CreateOrganizationRole()
clerk.Organizations.CreateRole()We could have one type for roles type Role struct but ideally the two methods above should accept different type of parameters.
There was a problem hiding this comment.
Makes sense, I will refactor this! And yes I agree, let’s start with different types for now
clerk/organization_roles_test.go
Outdated
| const dummyOrgRoleID = "role_1mebQggrD3xO5JfuHk7clQ94ysA" | ||
|
|
||
| const dummyOrgRoleJson = `{ | ||
| "object": "organization_role", |
There was a problem hiding this comment.
| "object": "organization_role", | |
| "object": "role", |
clerk/organization_roles_test.go
Outdated
| }` | ||
|
|
||
| const dummyUpdateOrgRoleJson = `{ | ||
| "object": "organization_role", |
There was a problem hiding this comment.
| "object": "organization_role", | |
| "object": "role", |
clerk/organization_roles.go
Outdated
|
|
||
| type OrganizationRolesService service | ||
|
|
||
| type OrganizationRole struct { |
There was a problem hiding this comment.
Do we want to have separate types for each role context or make it a generic one Role? Whatever we think is the best, let's make sure to align the Permission struct name as well
There was a problem hiding this comment.
Let’s keep it separate for now - I think it’s easier to understand this way what the struct is for!
mzhong9723
force-pushed
the
core-385-org-role-endpoints
branch
from
ea23bde to
bf08cdc
Compare
Type of change
Description
Add support for organization roles backend API endpoints