feat: Proxy checks service #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agis
approved these changes
Oct 25, 2023
chanioxaris
approved these changes
Oct 25, 2023
| DomainID: domain.ID, | ||
| ProxyURL: "https://" + domainName + "/__clerk", | ||
| }) | ||
| assert.NotNil(t, err) |
There was a problem hiding this comment.
Or maybe require is more appropriate
Suggested change
| assert.NotNil(t, err) | |
| assert.NoError(t, err) |
| Name: domainName, | ||
| IsSatellite: true, | ||
| }) | ||
| require.Nil(t, err) |
There was a problem hiding this comment.
Suggested change
| require.Nil(t, err) | |
| require.NoError(t, err) |
There was a problem hiding this comment.
There's a linter for these types of checks: https://github.com/Antonboom/testifylint#require-error
Should we enable it?
There was a problem hiding this comment.
Updated to use require.
Re: linter. I don't think it's necessary, but I have no objections.
Added a ProxyChecksService with a method to Create a proxy check. Triggers a request to the Backend API POST /v1/proxy_checks endpoint.
gkats
force-pushed
the
usr-383-create-proxy-checks
branch
from
8a58d46 to
1a1bf2e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
Added a ProxyChecksService with a method to Create a proxy check. Triggers a request to the Backend API POST /v1/proxy_checks endpoint.
Related Issue (optional)