chore: Adress PR comments

oauthapplication/client.go

@@ -4,6 +4,7 @@ package oauthapplication
 import (
 	"context"
 	"net/http"
+	"net/url"
 
 	"github.com/clerk/clerk-sdk-go/v2"
 )
@@ -39,7 +40,12 @@ type ListParams struct {
 	clerk.ListParams
 }
 
-// List retrieve all OAuth applications.
+func (params *ListParams) ToQuery() url.Values {
+	q := params.ListParams.ToQuery()
+	return q
+}
+
+// List retrieves all OAuth applications.
 func (c *Client) List(ctx context.Context, params *ListParams) (*clerk.OAuthApplicationList, error) {
 	req := clerk.NewAPIRequest(http.MethodGet, path)
 	req.SetParams(params)
@@ -48,32 +54,32 @@ func (c *Client) List(ctx context.Context, params *ListParams) (*clerk.OAuthAppl
 	return list, err
 }
 
-type OAuthApplicationCreateParams struct {
+type CreateParams struct {
 	clerk.APIParams
 	Name        string `json:"name"`
 	CallbackURL string `json:"callback_url"`
 	Scopes      string `json:"scopes"`
 	Public      bool   `json:"public"`
 }
 
-// Creates a new OAuth application with the given parameters.
-func (c *Client) Create(ctx context.Context, params *OAuthApplicationCreateParams) (*clerk.OAuthApplication, error) {
+// Create creates a new OAuth application with the given parameters.
+func (c *Client) Create(ctx context.Context, params *CreateParams) (*clerk.OAuthApplication, error) {
 	req := clerk.NewAPIRequest(http.MethodPost, path)
 	req.SetParams(params)
 	authApplication := &clerk.OAuthApplication{}
 	err := c.Backend.Call(ctx, req, authApplication)
 	return authApplication, err
 }
 
-type OAuthApplicationUpdateParams struct {
+type UpdateParams struct {
 	clerk.APIParams
 	Name        *string `json:"name,omitempty"`
 	CallbackURL *string `json:"callback_url,omitempty"`
 	Scopes      *string `json:"scopes,omitempty"`
 }
 
-// Update update an existing OAuth application.
-func (c *Client) Update(ctx context.Context, id string, params *OAuthApplicationUpdateParams) (*clerk.OAuthApplication, error) {
+// Update updates an existing OAuth application.
+func (c *Client) Update(ctx context.Context, id string, params *UpdateParams) (*clerk.OAuthApplication, error) {
 	path, err := clerk.JoinPath(path, id)
 	if err != nil {
 		return nil, err
@@ -85,7 +91,7 @@ func (c *Client) Update(ctx context.Context, id string, params *OAuthApplication
 	return authApplication, err
 }
 
-// Delete delete the given OAuth application
+// Delete deletes the given OAuth application
 func (c *Client) DeleteOAuthApplication(ctx context.Context, id string) (*clerk.DeletedResource, error) {
 	path, err := clerk.JoinPath(path, id)
 	if err != nil {
@@ -97,7 +103,7 @@ func (c *Client) DeleteOAuthApplication(ctx context.Context, id string) (*clerk.
 	return authApplication, err
 }
 
-// RotateClientSecret rotate the OAuth application's client secret
+// RotateClientSecret rotates the OAuth application's client secret
 func (c *Client) RotateClientSecret(ctx context.Context, id string) (*clerk.OAuthApplication, error) {
 	path, err := clerk.JoinPath(path, id, "rotate_secret")
 	if err != nil {

oauthapplication/client_test.go

@@ -34,7 +34,7 @@ func TestOAuthApplicationClientCreate(t *testing.T) {
 	}
 	client := NewClient(config)
 
-	params := &OAuthApplicationCreateParams{
+	params := &CreateParams{
 		Name:        name,
 		CallbackURL: callbackURL,
 		Scopes:      scopes,
@@ -66,7 +66,7 @@ func TestOrganizationClientCreate_Error(t *testing.T) {
 		},
 	}
 	client := NewClient(config)
-	_, err := client.Create(context.Background(), &OAuthApplicationCreateParams{})
+	_, err := client.Create(context.Background(), &CreateParams{})
 	require.Error(t, err)
 	apiErr, ok := err.(*clerk.APIErrorResponse)
 	require.True(t, ok)
@@ -121,7 +121,7 @@ func TestOAuthApplicationClientUpdate(t *testing.T) {
 	}
 
 	client := NewClient(config)
-	params := &OAuthApplicationUpdateParams{
+	params := &UpdateParams{
 		Name:        clerk.String(updatedName),
 		CallbackURL: clerk.String(callbackURL),
 	}
@@ -148,7 +148,7 @@ func TestOrganizationClientUpdate_Error(t *testing.T) {
 		},
 	}
 	client := NewClient(config)
-	_, err := client.Update(context.Background(), "oauth_123", &OAuthApplicationUpdateParams{})
+	_, err := client.Update(context.Background(), "oauth_123", &UpdateParams{})
 	require.Error(t, err)
 	apiErr, ok := err.(*clerk.APIErrorResponse)
 	require.True(t, ok)