fix: Accept role ID instead of Key for organization settings creator …

…role

We update the logic of the instance organization settings method in order
to accept a role ID instead of a Key for the default creator role. This is
because we should use an immutable identifier instead of the Key which
customers are able to modify

clerk/instances.go

@@ -100,7 +100,7 @@ type UpdateOrganizationSettingsParams struct {
 	AdminDeleteEnabled     *bool    `json:"admin_delete_enabled,omitempty"`
 	DomainsEnabled         *bool    `json:"domains_enabled,omitempty"`
 	DomainsEnrollmentModes []string `json:"domains_enrollment_modes,omitempty"`
-	CreatorRole            *string  `json:"creator_role,omitempty"`
+	CreatorRoleID          *string  `json:"creator_role_id,omitempty"`
 }
 
 func (s *InstanceService) UpdateOrganizationSettings(params UpdateOrganizationSettingsParams) (*OrganizationSettingsResponse, error) {

clerk/instances_test.go

@@ -126,10 +126,9 @@ func TestInstanceService_UpdateOrganizationSettings_happyPath(t *testing.T) {
 	})
 
 	enabled := true
-	defaultCreatorRole := "org:custom_admin"
 	got, _ := client.Instances().UpdateOrganizationSettings(UpdateOrganizationSettingsParams{
-		Enabled:     &enabled,
-		CreatorRole: &defaultCreatorRole,
+		Enabled:       &enabled,
+		CreatorRoleID: stringToPtr("role_2XcSZn6swGCjX59Nk0XbGer22jb"),
 	})
 
 	assert.Equal(t, &organizationSettingsResponse, got)