feat: Add block_disposable_emails param

clerk · Sep 26, 2023 · c5b7ccf · c5b7ccf
1 parent 7c24fcd
commit c5b7ccf
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 12 deletions.
diff --git a/clerk/instances.go b/clerk/instances.go
@@ -59,16 +59,18 @@ func (s *InstanceService) Update(params UpdateInstanceParams) error {
 }
 
 type InstanceRestrictionsResponse struct {
-	Object                 string `json:"object"`
-	Allowlist              bool   `json:"allowlist"`
-	Blocklist              bool   `json:"blocklist"`
-	BlockEmailSubaddresses bool   `json:"block_email_subaddresses"`
+	Object                      string `json:"object"`
+	Allowlist                   bool   `json:"allowlist"`
+	Blocklist                   bool   `json:"blocklist"`
+	BlockEmailSubaddresses      bool   `json:"block_email_subaddresses"`
+	BlockDisposableEmailDomains bool   `json:"block_disposable_email_domains"`
 }
 
 type UpdateRestrictionsParams struct {
-	Allowlist              *bool `json:"allowlist,omitempty"`
-	Blocklist              *bool `json:"blocklist,omitempty"`
-	BlockEmailSubaddresses *bool `json:"block_email_subaddresses,omitempty"`
+	Allowlist                   *bool `json:"allowlist,omitempty"`
+	Blocklist                   *bool `json:"blocklist,omitempty"`
+	BlockEmailSubaddresses      *bool `json:"block_email_subaddresses,omitempty"`
+	BlockDisposableEmailDomains *bool `json:"block_disposable_email_domains,omitempty"`
 }
 
 func (s *InstanceService) UpdateRestrictions(params UpdateRestrictionsParams) (*InstanceRestrictionsResponse, error) {

diff --git a/clerk/instances_test.go b/clerk/instances_test.go
@@ -59,10 +59,12 @@ func TestInstanceService_UpdateRestrictions_happyPath(t *testing.T) {
 	dummyRestrictionsResponseJSON := `{
 		"allowlist": true,
 		"blocklist": true,
-		"block_email_subaddresses": true
+		"block_email_subaddresses": true,
+		"block_disposable_email_domains": true
 	}`
 	var restrictionsResponse InstanceRestrictionsResponse
-	_ = json.Unmarshal([]byte(dummyRestrictionsResponseJSON), &restrictionsResponse)
+	err := json.Unmarshal([]byte(dummyRestrictionsResponseJSON), &restrictionsResponse)
+	assert.NoError(t, err)
 
 	client, mux, _, teardown := setup(token)
 	defer teardown()
@@ -75,9 +77,10 @@ func TestInstanceService_UpdateRestrictions_happyPath(t *testing.T) {
 
 	enabled := true
 	got, _ := client.Instances().UpdateRestrictions(UpdateRestrictionsParams{
-		Allowlist:              &enabled,
-		Blocklist:              &enabled,
-		BlockEmailSubaddresses: &enabled,
+		Allowlist:                   &enabled,
+		Blocklist:                   &enabled,
+		BlockEmailSubaddresses:      &enabled,
+		BlockDisposableEmailDomains: &enabled,
 	})
 
 	assert.Equal(t, &restrictionsResponse, got)

diff --git a/tests/integration/instances_test.go b/tests/integration/instances_test.go
@@ -40,6 +40,7 @@ func TestInstanceRestrictions(t *testing.T) {
 	assert.True(t, restrictionsResponse.Allowlist)
 	assert.True(t, restrictionsResponse.Blocklist)
 	assert.False(t, restrictionsResponse.BlockEmailSubaddresses)
+	assert.False(t, restrictionsResponse.BlockDisposableEmailDomains)
 }
 
 func TestInstanceOrganizationSettings(t *testing.T) {