Skip to content

Commit

Permalink
feat!: When creating a SAML Connection you are also required to provi…
Browse files Browse the repository at this point in the history
…de the provider type

We update our SAML Connection Create() method in order to also require the
'provider' property as Backend API from now on requires to be present.
This is a breaking change as it concerns the API, but the SAML feature is
still in Beta
  • Loading branch information
chanioxaris committed Jan 31, 2024
1 parent b8f5d47 commit 9b83650
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 0 deletions.
1 change: 1 addition & 0 deletions clerk/saml_connections.go
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,7 @@ func (s SAMLConnectionsService) Read(id string) (*SAMLConnection, error) {
type CreateSAMLConnectionParams struct {
Name string `json:"name"`
Domain string `json:"domain"`
Provider string `json:"provider"`
IdpEntityID *string `json:"idp_entity_id,omitempty"`
IdpSsoURL *string `json:"idp_sso_url,omitempty"`
IdpCertificate *string `json:"idp_certificate,omitempty"`
Expand Down
1 change: 1 addition & 0 deletions clerk/saml_connections_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,7 @@ func TestSAMLConnectionsService_Create(t *testing.T) {
createParams := &CreateSAMLConnectionParams{
Name: "Testing SAML",
Domain: "example.com",
Provider: "saml_custom",
IdpEntityID: stringToPtr("test-idp-entity-id"),
IdpSsoURL: stringToPtr("https://example.com/saml/sso"),
IdpCertificate: stringToPtr(dummySAMLConnectionCertificate),
Expand Down

0 comments on commit 9b83650

Please sign in to comment.