Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Organization inviterUserId as nullable #1819

Merged

Conversation

biutas
Copy link
Contributor

@biutas biutas commented Dec 17, 2024

Important

🔎 Previews:

Explanation:

This allows the inviterUserId to be nullable on the SDK, since it's nullable on the BAPI

image

This PR:

Update the types allowed

Checklist

  • I have clicked on "Files changed" and performed a thorough self-review
  • I have added the "deploy-preview" label and added the preview link(s) to this PR description
  • All existing checks pass

Copy link
Contributor

@victoriaxyz victoriaxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing to docs, @biutas!

Confirmed, the type definition for inviter_user_id is in this file.

@alexisintech alexisintech merged commit 81e4c1e into clerk:main Dec 17, 2024
@biutas
Copy link
Contributor Author

biutas commented Dec 19, 2024

The JS backend SDK still wrong, do you have any plans to merge this other PR to fix that @victoriaxyz @alexisintech ?

@victoriaxyz
Copy link
Contributor

Hey @biutas, I'll let someone from that team handle that PR. Thanks for letting us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants