Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: MetaMask Web3 authentication guide #1818

Merged
merged 5 commits into from
Dec 20, 2024
Merged

Conversation

chanioxaris
Copy link
Member

Important

🔎 Previews:

Explanation:

This PR:

Checklist

  • I have clicked on "Files changed" and performed a thorough self-review
  • I have added the "deploy-preview" label and added the preview link(s) to this PR description
  • All existing checks pass

@chanioxaris chanioxaris requested a review from a team as a code owner December 17, 2024 07:38
Copy link

Hey, here’s your docs preview: https://clerk.com/docs/pr/1818

Copy link
Contributor

@victoriaxyz victoriaxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @chanioxaris, here's my update: 70b27df

  • fix title and minor rewrite for grammar and style
  • mark "collect additional user information" section as optional and break down instructions into more granular steps

@@ -0,0 +1,47 @@
---
title: MetaMask Wallet
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe it's better to use just MetaMask as that's how everyone refers to it

Copy link
Member

@alexisintech alexisintech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!! 😸💖 feel free to merge when you're ready

@alexisintech alexisintech merged commit 5dacc19 into main Dec 20, 2024
3 checks passed
@alexisintech alexisintech deleted the haris/metamask-wallet branch December 20, 2024 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants