Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs for enterprise_sso and update examples #1770

Merged

Conversation

Nikpolik
Copy link
Member

@Nikpolik Nikpolik commented Dec 4, 2024

⚠️ Needs https://github.com/clerk/clerk/pull/857 merged for redirects

Explanation:

The saml authentication strategy has been superseded by a new enterprise_sso strategy that also allows for authentication with OIDC compatible providers besides SAML.

This PR:

  1. Adds enterprise_sso as a valid strategy for "authenticateWith" documentation and a deprecation warning in SAML
  2. Updates custom flows examples to use enterprise_sso

Checklist

  • I have clicked on "Files changed" and performed a thorough self-review
  • I have added the "deploy-preview" label and added the preview link(s) to this PR description
  • All existing checks pass

@Nikpolik Nikpolik self-assigned this Dec 4, 2024
@Nikpolik Nikpolik requested a review from a team as a code owner December 4, 2024 14:27
Copy link

github-actions bot commented Dec 4, 2024

Hey, here’s your docs preview: https://clerk.com/docs/pr/1770

@Nikpolik Nikpolik force-pushed the nikpolik/user-1108-write-docs-on-enterprise_sso-strategy branch from c161382 to d919811 Compare December 4, 2024 14:34
@alexisintech
Copy link
Member

posted my code review - let me know if it looks okay :)

@Nikpolik
Copy link
Member Author

Nikpolik commented Dec 9, 2024

@alexisintech ty for taking the time to improve this and adding the redirect (I didn't think about it sorry 🙏). ! Everything looks good 😄

Copy link
Member

@alexisintech alexisintech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amazing! thank you, and lets ship 😸💖

@Nikpolik Nikpolik merged commit 06da5f1 into main Dec 10, 2024
4 checks passed
@Nikpolik Nikpolik deleted the nikpolik/user-1108-write-docs-on-enterprise_sso-strategy branch December 10, 2024 09:24
royanger pushed a commit that referenced this pull request Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants