-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add changes for api version 2024-10-01 #1717
Add changes for api version 2024-10-01 #1717
Conversation
Hey, here’s your docs preview: https://clerk.com/docs/pr/1717 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks @Nikpolik!
0f35ce6
to
b366492
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Only minor nits.
Co-authored-by: victoria <[email protected]>
didn't mean to approve - meant to comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file says its for API versions with their respective breaking changes - are these breaking changes?
Also, I'm not quite sure what versions we're documenting here. It goes from 2021-02-05
all the way to 2024-10-01
. Did someone advise you to add this to this document, or what was the reasoning leading up to this PR?
@alexisintech In this file we document the Client and Backend API versions and their changes. It was initially added as part of the API versioning project (by me 🙃). This is actually the first api version ( Regarding if the changes are breaking, the response change definitely is as we changed how the API behaves for the same input. The new clients feature it's not exactly breaking but it will only work from this version and onward so it felt appropriate to mention it here. For some additional context there is a ClerkJS pr that starts utilising this new version (and will link to this doc) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
amazing, thank you providing more explanation and context!
Should have put some of this information in the PR description 😅 Sorry for that! |
Co-authored-by: victoria <[email protected]> Co-authored-by: Alexis Aguilar <[email protected]>
Co-authored-by: victoria <[email protected]> Co-authored-by: Alexis Aguilar <[email protected]>
Important
🔎 Previews:
This PR:
2024-10-01
in the appropriate listChecklist