Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add changes for api version 2024-10-01 #1717

Merged
merged 7 commits into from
Nov 28, 2024

Conversation

Nikpolik
Copy link
Member

@Nikpolik Nikpolik commented Nov 18, 2024

This PR:

  • Adds the changes for our new api version 2024-10-01 in the appropriate list

Checklist

  • I have clicked on "Files changed" and performed a thorough self-review
  • I have added the "deploy-preview" label and added the preview link(s) to this PR description
  • All existing checks pass

@Nikpolik Nikpolik self-assigned this Nov 18, 2024
@Nikpolik Nikpolik requested a review from gkats November 18, 2024 17:42
Copy link

Hey, here’s your docs preview: https://clerk.com/docs/pr/1717

Copy link
Member

@gkats gkats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @Nikpolik!

@Nikpolik Nikpolik force-pushed the nikpolik/user-1064-add-docs-for-new-api-version branch from 0f35ce6 to b366492 Compare November 19, 2024 09:54
@Nikpolik Nikpolik marked this pull request as ready for review November 25, 2024 09:28
@Nikpolik Nikpolik requested a review from a team as a code owner November 25, 2024 09:28
@victoriaxyz victoriaxyz self-requested a review November 26, 2024 21:39
Copy link
Contributor

@victoriaxyz victoriaxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Only minor nits.

alexisintech
alexisintech previously approved these changes Nov 27, 2024
@alexisintech alexisintech dismissed their stale review November 27, 2024 14:47

didn't mean to approve - meant to comment

Copy link
Member

@alexisintech alexisintech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file says its for API versions with their respective breaking changes - are these breaking changes?

Also, I'm not quite sure what versions we're documenting here. It goes from 2021-02-05 all the way to 2024-10-01. Did someone advise you to add this to this document, or what was the reasoning leading up to this PR?

@Nikpolik
Copy link
Member Author

Nikpolik commented Nov 27, 2024

@alexisintech In this file we document the Client and Backend API versions and their changes. It was initially added as part of the API versioning project (by me 🙃).

This is actually the first api version (2024-10-01) we will ever release, but we needed to label how the API worked up to now, 2021-02-05 was chosen, it's the date that clerk was publicly released for the first time. That's why there is such a big jump in the versions. From now on I imagine there will be a smaller gap.

Regarding if the changes are breaking, the response change definitely is as we changed how the API behaves for the same input.

The new clients feature it's not exactly breaking but it will only work from this version and onward so it felt appropriate to mention it here.

For some additional context there is a ClerkJS pr that starts utilising this new version (and will link to this doc)

Copy link
Member

@alexisintech alexisintech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amazing, thank you providing more explanation and context!

@Nikpolik
Copy link
Member Author

Should have put some of this information in the PR description 😅 Sorry for that!

@Nikpolik Nikpolik merged commit 07885ed into main Nov 28, 2024
4 checks passed
@Nikpolik Nikpolik deleted the nikpolik/user-1064-add-docs-for-new-api-version branch November 28, 2024 10:28
alexisintech added a commit that referenced this pull request Dec 6, 2024
Co-authored-by: victoria <[email protected]>
Co-authored-by: Alexis Aguilar <[email protected]>
royanger pushed a commit that referenced this pull request Dec 16, 2024
Co-authored-by: victoria <[email protected]>
Co-authored-by: Alexis Aguilar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants