Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update Tanstack Start #1714

Merged
merged 2 commits into from
Nov 20, 2024
Merged

fix: Update Tanstack Start #1714

merged 2 commits into from
Nov 20, 2024

Conversation

LekoArts
Copy link
Member

@LekoArts LekoArts commented Nov 15, 2024

Explanation:

This PR accompanies clerk/javascript#4575 (but can be merged independently) and basically updates our code to be up-to-date with Tanstack Start (so our SDK itself didn't change).

You can see examples of the changes also in the original Tanstack PR.

I also updated the quickstart: clerk/clerk-tanstack-start-quickstart#1

Checklist

  • I have clicked on "Files changed" and performed a thorough self-review
  • I have added the "deploy-preview" label and added the preview link(s) to this PR description
  • All existing checks pass

Copy link

Hey, here’s your docs preview: https://clerk.com/docs/pr/1714

Comment on lines +42 to +50
npm install @clerk/tanstack-start
```

```bash {{ filename: 'terminal' }}
yarn add @clerk/tanstack-start@beta
yarn add @clerk/tanstack-start
```

```bash {{ filename: 'terminal' }}
pnpm add @clerk/tanstack-start@beta
pnpm add @clerk/tanstack-start
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't actively publish the package under the @beta tag so the current beta tagged version is outdated compared to latest. We don't use that tag for other packages that are still Beta (e.g. Elements) so this changes it so that people installed the latest version

Copy link
Member

@panteliselef panteliselef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@LekoArts LekoArts merged commit 94f8b36 into main Nov 20, 2024
4 checks passed
@LekoArts LekoArts deleted the tanstack-start-updates branch November 20, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants