Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add initialValues property to <SignUpButton /> and <SignInButton /> #1707

Merged
merged 7 commits into from
Nov 18, 2024
Merged

Add initialValues property to <SignUpButton /> and <SignInButton /> #1707

merged 7 commits into from
Nov 18, 2024

Conversation

alexcarpenter
Copy link
Member

@alexcarpenter alexcarpenter commented Nov 14, 2024 •
edited
Loading

Important

🔎 Previews:

Explanation:

Hold until clerk/javascript#4567 is merged

init

This PR:

Checklist

  • I have clicked on "Files changed" and performed a thorough self-review
  • I have added the "deploy-preview" label and added the preview link(s) to this PR description
  • All existing checks pass

@alexcarpenter alexcarpenter requested a review from a team as a code owner November 14, 2024 20:12
@github-actions GitHub Actions
Copy link

Hey, here’s your docs preview: https://clerk.com/docs/pr/1707

@alexcarpenter alexcarpenter changed the title chore(SignUpButton): Add initialValues property to <SignUpButton /> feat(SignUpButton): Add initialValues property to <SignUpButton /> Nov 14, 2024
@alexcarpenter alexcarpenter changed the title feat(SignUpButton): Add initialValues property to <SignUpButton /> chore(SignUpButton): Add initialValues property to <SignUpButton /> Nov 14, 2024
victoriaxyz
victoriaxyz approved these changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@victoriaxyz victoriaxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2024-11-14 at 16 54 53

Nice!

@alexisintech alexisintech changed the title chore(SignUpButton): Add initialValues property to <SignUpButton /> (/sign-up-button): Add initialValues property to <SignUpButton /> Nov 15, 2024
@alexcarpenter alexcarpenter changed the title (/sign-up-button): Add initialValues property to <SignUpButton /> (/sign-up-button): Add initialValues property to <SignUpButton /> and <SignInButton /> Nov 15, 2024
@alexcarpenter alexcarpenter changed the title (/sign-up-button): Add initialValues property to <SignUpButton /> and <SignInButton /> Add initialValues property to <SignUpButton /> and <SignInButton /> Nov 15, 2024
@alexcarpenter
Copy link
Member Author

@victoriaxyz small update since your review, added the same initialValues option to <SignInButton /> as well clerk/javascript#4581

@alexcarpenter
Copy link
Member Author

Can merge once clerk/javascript#4576 is released

@victoriaxyz victoriaxyz self-requested a review November 15, 2024 21:43
@alexcarpenter alexcarpenter merged commit c5015e1 into main Nov 18, 2024
4 checks passed
@alexcarpenter alexcarpenter deleted the alexcarpenter/sign-up-button-initial-values branch November 18, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@victoriaxyz victoriaxyz victoriaxyz approved these changes

Assignees
No one assigned
Labels
deploy-preview
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexcarpenter @victoriaxyz