Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cypress): Restructure and add Account Portal section #1679

Conversation

anagstef
Copy link
Member

@anagstef anagstef commented Nov 5, 2024

@anagstef anagstef requested a review from a team as a code owner November 5, 2024 20:15
@anagstef anagstef self-assigned this Nov 5, 2024
Copy link

github-actions bot commented Nov 5, 2024

Hey, here’s your docs preview: https://clerk.com/docs/pr/1679

docs/testing/cypress/custom-commands.mdx Outdated Show resolved Hide resolved
docs/testing/cypress/custom-commands.mdx Outdated Show resolved Hide resolved
docs/testing/cypress/overview.mdx Outdated Show resolved Hide resolved
docs/testing/cypress/overview.mdx Outdated Show resolved Hide resolved
docs/testing/cypress/overview.mdx Outdated Show resolved Hide resolved
docs/testing/cypress/overview.mdx Outdated Show resolved Hide resolved
Copy link
Contributor

@victoriaxyz victoriaxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

Please check the PR I opened in the quickstart to ensure the code in the test file matches the code you wrote for these docs: clerk/clerk-cypress-nextjs#9

I ran the code and there are errors.

Also, please replace all real Account Portal URLs with mock data.

docs/testing/cypress/custom-commands.mdx Outdated Show resolved Hide resolved
docs/testing/cypress/custom-commands.mdx Outdated Show resolved Hide resolved
docs/testing/cypress/overview.mdx Outdated Show resolved Hide resolved
docs/testing/cypress/overview.mdx Outdated Show resolved Hide resolved
docs/testing/cypress/overview.mdx Outdated Show resolved Hide resolved
docs/testing/cypress/test-account-portal.mdx Outdated Show resolved Hide resolved
docs/testing/cypress/test-account-portal.mdx Outdated Show resolved Hide resolved
docs/testing/cypress/test-account-portal.mdx Outdated Show resolved Hide resolved
docs/testing/cypress/test-account-portal.mdx Outdated Show resolved Hide resolved
docs/testing/cypress/test-account-portal.mdx Outdated Show resolved Hide resolved
anagstef and others added 15 commits November 8, 2024 19:30
docs/manifest.json Outdated Show resolved Hide resolved
@anagstef anagstef merged commit 4fbff20 into main Nov 15, 2024
4 checks passed
@anagstef anagstef deleted the stefanos/eco-53-cypress-add-how-to-test-account-portal-on-cypress-docs-page branch November 15, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants