-
Notifications
You must be signed in to change notification settings - Fork 484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOCS-9362 Fix the CSRF page #1624
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hey, here’s your docs preview: https://clerk.com/docs/pr/1624 |
Co-authored-by: Alexis Aguilar <[email protected]>
Co-authored-by: Alexis Aguilar <[email protected]>
Co-authored-by: Alexis Aguilar <[email protected]>
Co-authored-by: Alexis Aguilar <[email protected]>
Co-authored-by: Alexis Aguilar <[email protected]>
Co-authored-by: Alexis Aguilar <[email protected]>
Co-authored-by: Alexis Aguilar <[email protected]>
Co-authored-by: Alexis Aguilar <[email protected]>
victoriaxyz
approved these changes
Oct 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved pending @alexisintech 👀
alexisintech
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
🔎 Previews:
Explanation:
The CSRF page contained inaccurate links and inaccurate statements, and generally didn't adequately explain what a CSRF attack is and how Clerk helps to prevent them. This set of edits should fix that up!
Also just food for thought - while Clerk does add a lot of important security guarantees throughout the product, this is one of the less impactful ones, since all we do is use the default value and not change the samesite flag on cookies to an insecure option. To be fair, there are plenty of cases in which people will do this and unwittingly open themselves to attack, but you'd kind of have to go out of your way to make a mistake in order to do so, which is why I say while it's not value-less, it's not our strongest security guarantee. Especially compared with the 1m expiration JWTs substantially hamper XSS attackers, which is a much more unique and impactful security feature of our architecture. And I don't think we really go through and explain that on any of our other docs pages, other than a VERY small mention here 🤷♂️