Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(/authentication/social-connections/github) update guide #1602

Merged
merged 20 commits into from
Oct 11, 2024
Merged

(/authentication/social-connections/github) update guide #1602

merged 20 commits into from
Oct 11, 2024

Conversation

victoriaxyz
Copy link
Contributor

@victoriaxyz victoriaxyz commented Oct 4, 2024 •
edited
Loading

Important

🔎 Previews:

Explanation:

This PR:

  • does a lot

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 4, 2024

Hey, here’s your docs preview: https://clerk.com/docs/pr/1602

@victoriaxyz victoriaxyz marked this pull request as ready for review October 9, 2024 16:32
@victoriaxyz victoriaxyz requested a review from a team as a code owner October 9, 2024 16:32
alexisintech
alexisintech reviewed Oct 9, 2024
View reviewed changes
Copy link
Member

@alexisintech alexisintech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we usually split "Create a app" and "Set the Client ID and Client Secret in your Clerk Dashboard"

Do you want to shy away from that and do something more concise like this? Or should we stick with that format

docs/authentication/social-connections/github.mdx Outdated Show resolved Hide resolved
docs/authentication/social-connections/github.mdx Outdated Show resolved Hide resolved
docs/authentication/social-connections/github.mdx Outdated Show resolved Hide resolved
docs/authentication/social-connections/github.mdx Outdated Show resolved Hide resolved
docs/authentication/social-connections/github.mdx Outdated Show resolved Hide resolved
alexisintech
alexisintech reviewed Oct 11, 2024
View reviewed changes
docs/authentication/social-connections/github.mdx Outdated
1. Select **Register application**. You'll be redirected to your GitHub app's **General** page.
1. Select **Generate a new client secret**. Save your **Client ID** and **Client secret** somewhere secure. Keep the modal and page open.
1. Select **Generate a new client secret**.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we move this to the next step? see the next comment

docs/authentication/social-connections/github.mdx Outdated Show resolved Hide resolved
@alexisintech alexisintech merged commit 74939e4 into main Oct 11, 2024
4 checks passed
@alexisintech alexisintech deleted the vi/docs-363/oauth-github branch October 11, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexisintech alexisintech alexisintech approved these changes

Assignees
No one assigned
Labels
deploy-preview
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@victoriaxyz @alexisintech