Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs-9205: change appearance prop color from red to purple #1536

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

victoriaxyz
Copy link
Contributor

@victoriaxyz victoriaxyz commented Sep 13, 2024

Important

🔎 Previews:

Explanation:

This PR:

  • changes the appearance prop color from red to purple so the code example matches Clerk's colors

@victoriaxyz victoriaxyz requested a review from a team as a code owner September 13, 2024 18:03
Copy link

Hey, here’s your docs preview: https://clerk.com/docs/pr/1536

@alexisintech alexisintech merged commit 9645fbf into main Sep 13, 2024
4 checks passed
@alexisintech alexisintech deleted the vi/docs-9205/appearance-color branch September 13, 2024 18:43
@@ -156,7 +156,7 @@ In the following example, the primary color is set to red and the text color is
<ClerkProvider
appearance={{
variables: {
colorPrimary: 'red',
colorPrimary: 'purple',
colorText: 'white',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the biggest offender here was the colorText usage, which hides all of the text in the card.
Screenshot 2024-09-13 at 2 47 24 PM

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will open a new PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants