Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supabase doc updates #1224

Merged
merged 24 commits into from
Jul 19, 2024
Merged

Supabase doc updates #1224

merged 24 commits into from
Jul 19, 2024

Conversation

bmorrisondev
Copy link
Contributor

@bmorrisondev bmorrisondev commented Jul 3, 2024

Important

🔎 Preview:

I walked through this document for the first time today and found a number of areas that could be expanded on or improved for clarity.

This includes:

  • Adding context as to what the guide is, and is not
  • Adding details on using the SQL editor moer
  • Reordering the steps to create the requesting_user_id first (Step 1 does not work otherwise)
  • Expanding on the RLS policies
  • A small tweak based on our UI changes

@bmorrisondev bmorrisondev requested a review from a team as a code owner July 3, 2024 20:56
Copy link

github-actions bot commented Jul 3, 2024

Hey, here’s your docs preview: https://clerk.com/docs/pr/1224

@alexisintech alexisintech marked this pull request as draft July 5, 2024 18:12
@bmorrisondev bmorrisondev changed the title [DO NOT MERGE] Supabase doc updates Supabase doc updates Jul 5, 2024
@bmorrisondev bmorrisondev marked this pull request as ready for review July 5, 2024 19:35
@alexisintech alexisintech marked this pull request as draft July 9, 2024 20:37
@bmorrisondev bmorrisondev marked this pull request as ready for review July 12, 2024 16:09
docs/integrations/databases/supabase.mdx Outdated Show resolved Hide resolved
docs/integrations/databases/supabase.mdx Outdated Show resolved Hide resolved
docs/integrations/databases/supabase.mdx Outdated Show resolved Hide resolved
@alexisintech alexisintech requested a review from jescalan July 19, 2024 00:23
Copy link
Contributor

@jescalan jescalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really impressive work here 👏

It's quite an involved guide and I wonder if there's anything we can do to like, automate some of these steps or make it less of an episode to get the integration done, but after reading it through nothing is jumping out to me. It may just be what it is!

@bmorrisondev
Copy link
Contributor Author

Really impressive work here 👏

It's quite an involved guide and I wonder if there's anything we can do to like, automate some of these steps or make it less of an episode to get the integration done, but after reading it through nothing is jumping out to me. It may just be what it is!

@bmorrisondev
Copy link
Contributor Author

My mistake on closing this!

We could build a small CLI that hooks into the database using the connection string to run the necessary SQL on the required tables. Do we have a way of determining how popular this integration is? Maybe checking how many people have a supabase jwt template?

@alexisintech alexisintech merged commit e24e83f into main Jul 19, 2024
5 checks passed
@alexisintech alexisintech deleted the sb-integration-guide-updates branch July 19, 2024 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants