changed compiler pass to have the api service become an alias of the …

…mocked api service instead of changing classes
cleentfaar · Feb 21, 2015 · c262163 · c262163
1 parent ad9c71b
commit c262163
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 15 deletions.
diff --git a/DependencyInjection/Compiler/RegisterApiClientPass.php b/DependencyInjection/Compiler/RegisterApiClientPass.php
@@ -10,10 +10,11 @@ class RegisterApiClientPass implements CompilerPassInterface
     public function process(ContainerBuilder $container)
     {
         $clientId = 'cl_slack.api_client';
+        $mockClientId = 'cl_slack.mock_api_client';
 
         if (!$container->hasDefinition($clientId) ||
-            !$container->hasParameter('cl_slack.test') ||
-            !$container->hasParameter('cl_slack.mock_api_client.class')
+            !$container->hasDefinition($mockClientId) ||
+            !$container->hasParameter('cl_slack.test')
         ) {
             return;
         }
@@ -22,7 +23,7 @@ public function process(ContainerBuilder $container)
             return;
         }
 
-        $clientDefinition = $container->getDefinition($clientId);
-        $clientDefinition->setClass($container->getParameter('cl_slack.mock_api_client.class'));
+        $container->removeDefinition($clientId);
+        $container->setAlias($clientId, $mockClientId);
     }
 }
diff --git a/Tests/DependencyInjection/Compiler/RegisterApiClientPassTest.php b/Tests/DependencyInjection/Compiler/RegisterApiClientPassTest.php
@@ -9,21 +9,22 @@
 
 class RegisterApiClientPassTest extends AbstractCompilerPassTestCase
 {
-    protected function registerCompilerPass(ContainerBuilder $container)
-    {
-        $container->addCompilerPass(new RegisterApiClientPass());
-    }
-    /**
-     * @test
-     */
     public function testApiClientIsMockedWhenTestIsTrue()
     {
-        $collectingService = new Definition();
-        $this->setDefinition('cl_slack.api_client', $collectingService);
+        $apiClientId     = 'cl_slack.api_client';
+        $mockApiClientId = 'cl_slack.mock_api_client';
+
+        $this->setDefinition($apiClientId, new Definition());
+        $this->setDefinition($mockApiClientId, new Definition());
         $this->setParameter('cl_slack.test', true);
-        $this->setParameter('cl_slack.mock_api_client.class', 'TestClass');
+
         $this->compile();
 
-        $this->assertContainerBuilderHasService('cl_slack.api_client', 'TestClass');
+        $this->assertContainerBuilderHasAlias($apiClientId, $mockApiClientId);
+    }
+
+    protected function registerCompilerPass(ContainerBuilder $container)
+    {
+        $container->addCompilerPass(new RegisterApiClientPass());
     }
 }