Skip to content
This repository has been archived by the owner on Jun 12, 2023. It is now read-only.

Add some more C++ extensions #15

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

velichkov
Copy link

Google C++ style guide requires .cc extension and also gcc supports few more extensions - .cxx, .CPP, c++, .cp and .C

Also improve the testing instructions in the README.md

@VictorRodriguez
Copy link
Contributor

Hi @velichkov
thanks a lot for the PR. I will take time to day to review and post my comments.

@ahkok
Copy link

ahkok commented Nov 19, 2019

It seems unnecessary to duplicate the same source code file 7x. Perhaps we can make a temporary copy for each iteration and use that to validate, instead. Or even symlinks?

@velichkov
Copy link
Author

Hi @ahkok,

It seems unnecessary to duplicate the same source code file 7x.

Agree.

Perhaps we can make a temporary copy for each iteration and use that to validate, instead.

I'll try to to rework it with temporary copies.

Or even symlinks?

With symlinks it would be tricky as patch refuses to patch symlinks

File tests/max-test.cc is not a regular file -- refusing to patch
1 out of 1 hunk ignored -- saving rejects to file tests/max-test.cc.rej

and with --follow-symlinks option

patching file tests/max-test.CPP
Reversed (or previously applied) patch detected!  Assume -R? [n]

and with --follow-symlinks -f it returns 1

patching file tests/max-test.cxx
Hunk #1 FAILED at 11.
1 out of 1 hunk FAILED -- saving rejects to file tests/max-test.cxx.rej
$ echo $?
1

@VictorRodriguez
Copy link
Contributor

Agree on comments from @ahkok we can make a temporary copy for each iteration. Thanks a lot for the patch !

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants