Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Wip] Return sensible error in integer-decode-float when called with a infinity value #940

Closed

Conversation

kpoeck
Copy link
Contributor

@kpoeck kpoeck commented Mar 12, 2020

  • issue encountered while cross-compiling sbcl (and the origin is still to be clarified)
  • return sensible error instead of sigfpe as before
  • added test to regression-suite

@Bike
Copy link
Member

Bike commented Mar 13, 2020

Preferably we should figure out how to transmute a SIGFPE into a floating point error, because otherwise we'd have to put checks like this on every floating point operation. I thought I had it doing that already, but evidently not. Either the error isn't one of the ones we handle, or the traps are just totally messed up. Code is here: https://github.com/clasp-developers/clasp/blob/dev/src/gctools/interrupt.cc#L256-L271

@kpoeck kpoeck changed the title Return sensible error in integer-decode-float when called with a infinity value [Wip] Return sensible error in integer-decode-float when called with a infinity value Mar 21, 2020
@kpoeck
Copy link
Contributor Author

kpoeck commented Mar 28, 2020

I hope in #955 I have this fixed as you intended

@Bike
Copy link
Member

Bike commented Apr 19, 2020

yes. is this PR dead, then? incorporating the tests would be good, but #961 precludes that.

@kpoeck
Copy link
Contributor Author

kpoeck commented Apr 20, 2020

As you said, this pr is dead. I have stored the tests locally, but as you said, we can't add them right now. I wonder whether we need something like (ext:issue-fixed-p :961)

@Bike Bike closed this Apr 20, 2020
@kpoeck kpoeck deleted the fix-integer-decode-float-infinity branch April 17, 2021 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants