Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koga enhancements: defines, *.cxx and *.hpp as sources. #1640

Merged
merged 1 commit into from
Oct 19, 2024

Conversation

dg1sbg
Copy link
Contributor

@dg1sbg dg1sbg commented Oct 19, 2024

This PR brings the following enhancements to koga:

  1. Add source files with endings .cxx and .hpp as valid C++ source and header files.
  2. Allow for #define statements being added in cscript files: (koga:defines "XYZ=ABC") adds -DXYZ=ABC to cflags.

The PR also includes a minor correction for a debug message saying that the locaton of an extension is taken from its repo definiton.

@yitzchak yitzchak merged commit 7f1f296 into clasp-developers:main Oct 19, 2024
9 checks passed
@yitzchak
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants