implement all special operators in bytecode #1622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
because i'm sick of seeing catch-function in backtraces, mostly, which isn't a very good reason A slightly better reason is that makes it easier to load Maclina FASLs.
replacing the macro that expands into a funwind-protect call.
Assuming the name existed caused a weird type error when it didn't. Whoops! Happens with e.g. signal handlers.
Also makes it so you can specify the thunk in C++, which will be needed for bytecode.
that covers all the special operators.
No longer used.
Will be useful for compiling catch instructions... but we can't right now since they're not actually represented in Cleavir. Oops!
Bike
force-pushed
the
bytecode-all-special-operators
branch
from
185f714 to
060c448
Compare
Forgot I made that change to Cleavir. Should probably be better thought out but this at least fixes the MISC.105 failure. Currently I'm focusing on the bytecode bootstrapping stuff before even worrying about Cleavir again. It's a lot, though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what it says on the tin. removes the need for
catch-functionand stuff with bytecode. Improves parity with Maclina.But they're not in there in Cleavir, so the BTB compiler doesn't work on some stuff. I'm going to call that optional, especially since I just noticed the ast-interpreter-n tests have been failing to compile for weeks and it hasn't caused any big issues.