Convert lisp stream dispatch to virtual methods #1531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bike
approved these changes
Dec 18, 2023
| claspCharacter decode_passthrough(unsigned char** buffer, unsigned char* buffer_end); | ||
| int encode_passthrough(unsigned char* buffer, claspCharacter c); | ||
|
|
||
| claspCharacter decode_ascii(unsigned char** buffer, unsigned char* buffer_end); |
There was a problem hiding this comment.
Might be good to move out all these methods to some general class rather than FileStream. (something for the later changes, of course)
| l = compute_char_size(string.unsafe_character()); | ||
| } else if (cl__stringp(string)) { | ||
| Fixnum iEnd; | ||
| String_sp sb = string.asOrNull<String_O>(); |
There was a problem hiding this comment.
Obviously this is just code you're copying and so fixing it is a bit out of scope, but just to mention (you probably already know):
- asOrNull is to be avoided. we have
gc::Asetc - this conditional is pointless, since
cl__lengthwill return the fill pointer - ditto StringFillp and SetStringFillp. they should be on the chopping block
src/core/lispStream.cc
Outdated
| unlikely_if(!AnsiStreamP(strm)) ERROR_WRONG_TYPE_ONLY_ARG(cl::_sym_open_stream_p, strm, cl::_sym_Stream_O); | ||
| return (StreamClosed(strm) ? nil<T_O>() : _lisp->_true()); | ||
| AnsiStream_sp ansi_stream = strm.asOrNull<AnsiStream_O>(); | ||
| return ansi_stream ? (ansi_stream->_Closed ? nil<T_O>() : _lisp->_true()) : eval::funcall(gray::_sym_open_stream_p, strm); |
There was a problem hiding this comment.
maybe oughta have a reader rather than using a field directly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.