Fix error return on gray read-byte #1524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yitzchak
force-pushed
the
fix-read-byte
branch
from
fa45347 to
b9761eb
Compare
Bike
approved these changes
Nov 30, 2023
src/core/lispStream.cc
Outdated
| return eof_value; | ||
|
|
||
| ERROR_END_OF_FILE(strm); | ||
|
|
||
| return c; |
There was a problem hiding this comment.
Is this return reachable? ERROR_END_OF_FILE is properly [[noreturn]], i hope
There was a problem hiding this comment.
Yeah, I guess it should be inverted or removed.
There was a problem hiding this comment.
And lisp_error is [[noreturn]] so that is fine.
yitzchak
force-pushed
the
fix-read-byte
branch
from
b9761eb to
0e76ac9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
cl:read-byteignoreseof-error-pandeof-valuearguments for Gray streams.clasp_read_bytealready handles EOF correctly via the dispatch tables so I just removed the unneeded special code for Gray streams.