Decent error when bytecompiling setq of a constant

Could be more sophisticated, but this at least prevents the hard crash. Fixes #1613.
clasp-developers · Aug 3, 2024 · b4e79dc · b4e79dc
1 parent 01cf28c
commit b4e79dc
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/src/core/bytecode_compiler.cc b/src/core/bytecode_compiler.cc
@@ -2266,8 +2266,10 @@ static void compile_setq_1(Symbol_sp var, T_sp valf, Lexenv_sp env, const Contex
     }
     if (ctxt.receiving() == -1)
       ctxt.assemble0(vm_pop);
-  } else
-    UNREACHABLE();
+  } else if (std::holds_alternative<ConstantVarInfoV>(info)) {
+    // FIXME: Better error (warning?)
+    SIMPLE_ERROR("Cannot modify constant {}", var->__repr__());
+  } else UNREACHABLE();
 }
 
 void compile_setq(List_sp pairs, Lexenv_sp env, const Context ctxt) {