Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linear Clash.Sized.Vector.reverse (copy #2871) #2872

Open
wants to merge 1 commit into
base: 1.8
Choose a base branch
from

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Jan 7, 2025

The current implementation of Clash.Sized.Vector.reverse has a simulation runtime that is quadratic in the input. This PR improves this to a linear version.

Still TODO:

  • Write a changelog entry (see changelog/README.md)
  • Check copyright notices are up to date in edited files

This is an automatic copy of pull request #2871 done by [Mergify](https://mergify.com).

Improve the simulation runtime of `Clash.Sized.Vector.reverse` from quadratic to linear.

(cherry picked from commit e07ea48)

# Conflicts:
#	clash-prelude/src/Clash/Sized/Vector.hs
@mergify mergify bot added the conflicts label Jan 7, 2025
Copy link
Author

mergify bot commented Jan 7, 2025

Cherry-pick of e07ea48 has failed:

On branch mergify/copy/1.8/pr-2871
Your branch is up to date with 'origin/1.8'.

You are currently cherry-picking commit e07ea489.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   clash-prelude/src/Clash/Sized/Vector.hs

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant