Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data AT #710

Merged
merged 12 commits into from
Sep 18, 2023
Merged

Data AT #710

merged 12 commits into from
Sep 18, 2023

Conversation

hpreki
Copy link
Collaborator

@hpreki hpreki commented Jul 19, 2023

new sample for ParlaMint-3.1:

  • updated Metadata
  • removed sample protocol XVII-00159 and replaced it with XVII-00178 (i.e. the current most recent protocol in ParlaMint-AT)

@hpreki
Copy link
Collaborator Author

hpreki commented Jul 19, 2023

the 1st pull request failed because

  • the new @role federatedState is not yet part of the Schema in data branch - only in the branch documentation
  • add-common-content now adds a new subcorpus-type #war which is not yet part of my ParlaMint-taxonomy-subcorpus.xml
    @matyaskopp is there any action required from my side? I suppose you would update the Schema in the data branch?

In the meantime I updated Data/ParlaMint-taxonomy-subcorpus.xml in my fork but I will wait with a new pull-request until Schema/ParlaMint.* has been brought up to date ( I did not dare to simply copy the files from the documentation branch to the data branch because there are some tiny differences apart from the federatedState )

@TomazErjavec
Copy link
Collaborator

This is a very old pull request - is it still relevant, or can we close it?

@hpreki
Copy link
Collaborator Author

hpreki commented Sep 15, 2023

@TomazErjavec is there a chance we can still finish this pull request? Especially I would like to see Data/ParlaMint-AT/ParlaMint-AT-listPerson.xml be up to date in the repo. (The current version in the repo is outdated and would not validate. A correct(ed) version of listPerson was handed in to you as part of our submission for ParlaMint-3.1, but this was via a Web-share and never made it into the git-repo.)

@TomazErjavec
Copy link
Collaborator

@TomazErjavec is there a chance we can still finish this pull request?

I don't think we can, because the repo structure has changed in the meantime (we don't have Data/ anymore, rather, Samples/). But @matyaskopp is more in tune with the git maintenance.
In any case, your files will make it to GitHub, but now with everybody sending fixes and translations, it is a bit chaotic.

@matyaskopp
Copy link
Collaborator

@hpreki

there is an isssue that your repo is out of date and the Data folder has been renamed to Sample
I think this procedure will work:

  1. backup your sample files on your local host:
cp -r Data/ParlaMint-AT ParlaMint-AT-BACKUP
  1. remove the files from repository:
git rm Data/ParlaMint-AT/ParlaMint-AT-listOrg.xml \
Data/ParlaMint-AT/ParlaMint-AT-listPerson.xml \
Data/ParlaMint-AT/ParlaMint-AT.ana.xml \
Data/ParlaMint-AT/ParlaMint-AT.xml \
Data/ParlaMint-AT/ParlaMint-AT_2005-03-31-022-XXII-NRSITZ-00100.ana.xml \
Data/ParlaMint-AT/ParlaMint-AT_2005-03-31-022-XXII-NRSITZ-00100.xml \
Data/ParlaMint-AT/ParlaMint-AT_2014-09-24-025-XXV-NRSITZ-00042.ana.xml \
Data/ParlaMint-AT/ParlaMint-AT_2014-09-24-025-XXV-NRSITZ-00042.xml \
Data/ParlaMint-AT/ParlaMint-taxonomy-NER.ana.xml \
Data/ParlaMint-AT/ParlaMint-taxonomy-speaker_types.xml \
Data/ParlaMint-AT/ParlaMint-taxonomy-subcorpus.xml 
  1. commit and push
git commit -m "remove AT files" Data/ParlaMint-AT
git push
  1. sync your fork hpreki/ParlaMint@data...clarin-eric:ParlaMint:data
  2. add files to correct folder (Sample/PArlaMint-AT)

@hpreki
Copy link
Collaborator Author

hpreki commented Sep 18, 2023

@matyaskopp thanks a lot for your detailed "cooking recipe"! I followed your advice, and the pull request looks much better to me right now: it seems to me that it passed all checks.

@matyaskopp matyaskopp merged commit ace1a34 into clarin-eric:data Sep 18, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants