Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mangen: split option into options and global options #5845

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 25 additions & 3 deletions clap_mangen/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -159,6 +159,10 @@ impl Man {
self._render_options_section(&mut roff);
}

if app_has_global_arguments(&self.cmd) {
self._render_global_options_section(&mut roff);
}

if app_has_subcommands(&self.cmd) {
self._render_subcommands_section(&mut roff);
}
Expand Down Expand Up @@ -245,7 +249,18 @@ impl Man {

fn _render_options_section(&self, roff: &mut Roff) {
roff.control("SH", ["OPTIONS"]);
render::options(roff, &self.cmd);

let is_not_global = |arg: &clap::Arg| !arg.is_global_set();
render::options(roff, &self.cmd, is_not_global);
render::options_postional(roff, &self.cmd, is_not_global);
}

fn _render_global_options_section(&self, roff: &mut Roff) {
roff.control("SH", ["GLOBAL OPTIONS"]);

let is_global = |arg: &clap::Arg| arg.is_global_set();
render::options(roff, &self.cmd, is_global);
render::options_postional(roff, &self.cmd, is_global);
}

/// Render the SUBCOMMANDS section into the writer.
Expand Down Expand Up @@ -307,9 +322,16 @@ fn app_has_version(cmd: &clap::Command) -> bool {
.is_some()
}

// Does the application have any command line arguments?
// Does the application have any non-global command line arguments?
fn app_has_arguments(cmd: &clap::Command) -> bool {
cmd.get_arguments().any(|i| !i.is_hide_set())
cmd.get_arguments()
.any(|i| !i.is_hide_set() && !i.is_global_set())
}

// Does the application have any global command line arguments?
fn app_has_global_arguments(cmd: &clap::Command) -> bool {
cmd.get_arguments()
.any(|i| !i.is_hide_set() && i.is_global_set())
}

// Does the application have any subcommands?
Expand Down
22 changes: 17 additions & 5 deletions clap_mangen/src/render.rs
Original file line number Diff line number Diff line change
Expand Up @@ -88,10 +88,12 @@ pub(crate) fn synopsis(roff: &mut Roff, cmd: &clap::Command) {
roff.text(line);
}

pub(crate) fn options(roff: &mut Roff, cmd: &clap::Command) {
let items: Vec<_> = cmd.get_arguments().filter(|i| !i.is_hide_set()).collect();

for opt in items.iter().filter(|a| !a.is_positional()) {
pub(crate) fn options(roff: &mut Roff, cmd: &clap::Command, mut filter: impl FnMut(&Arg) -> bool) {
for opt in cmd
.get_arguments()
.filter(|i| !i.is_hide_set() && !i.is_positional())
.filter(|&arg| filter(arg))
{
let mut header = match (opt.get_short(), opt.get_long()) {
(Some(short), Some(long)) => {
vec![short_option(short), roman(", "), long_option(long)]
Expand Down Expand Up @@ -132,8 +134,18 @@ pub(crate) fn options(roff: &mut Roff, cmd: &clap::Command) {
roff.control("RE", []);
}
}
}

for pos in items.iter().filter(|a| a.is_positional()) {
pub(crate) fn options_postional(
roff: &mut Roff,
cmd: &clap::Command,
mut filter: impl FnMut(&Arg) -> bool,
) {
for pos in cmd
.get_arguments()
.filter(|i| !i.is_hide_set() && i.is_positional())
.filter(|&arg| filter(arg))
{
let mut header = vec![];
let (lhs, rhs) = option_markers(pos);
header.push(roman(lhs));
Expand Down
7 changes: 4 additions & 3 deletions clap_mangen/tests/snapshots/basic.bash.roff
Original file line number Diff line number Diff line change
Expand Up @@ -7,15 +7,16 @@ my\-app
\fBmy\-app\fR [\fB\-c \fR] [\fB\-v \fR] [\fB\-h\fR|\fB\-\-help\fR] [\fIsubcommands\fR]
.SH DESCRIPTION
.SH OPTIONS
.TP
\fB\-c\fR

.TP
\fB\-v\fR

.TP
\fB\-h\fR, \fB\-\-help\fR
Print help
.SH "GLOBAL OPTIONS"
.TP
\fB\-c\fR

.SH SUBCOMMANDS
.TP
my\-app\-test(1)
Expand Down
Loading