fix(builder): don't require mut for is_multiple #4704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epage
reviewed
Feb 13, 2023
| @@ -270,7 +270,7 @@ impl ArgGroup { | |||
| /// | |||
| /// assert!(group.is_multiple()); | |||
| /// ``` | |||
| pub fn is_multiple(&mut self) -> bool { | |||
| pub fn is_multiple(&self) -> bool { | |||
There was a problem hiding this comment.
This looks to b a breaking change as you can no longer capture the function with the old signature (example).
Options:
- Create an issue and we can flag it for v5
- Put this change behind the
unstable-v5feature flag
|
Oh interesting. I didn't realize this would be a breaking change. My bad. I'll make an issue in a bit and we can just flag it for v5. In the mean time, I'll just use |
epage
added
the
M-breaking-change
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While pursuing an implementation for #4574, I noticed the that the
is_multiplefunction requires a mutable reference toself. But this function is just a simple accessor. Themutrequirement is onerous. Let's relax the requirement so that we don't need to have a mutable version of anArgGroupjust to check if it allows multiple arguments.