Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mangen): Respect more hide values #4271

Merged
merged 1 commit into from
Sep 27, 2022
Merged

fix(mangen): Respect more hide values #4271

merged 1 commit into from
Sep 27, 2022

Conversation

tahmid-23
Copy link
Contributor

@tahmid-23 tahmid-23 commented Sep 27, 2022

Respect remaining hidden flags

  • Arg::hide_default_value
  • Arg::hide_long_help
  • Arg::hide_short_help

Fixes #3361

@epage
Copy link
Member

epage commented Sep 27, 2022

(it seems to cover everything?).

Doing another look through, I see that we aren't covering Command::hide_possible_values. Would you like to cover that in this PR or should we defer it out?

@tahmid-23
Copy link
Contributor Author

that flag propagates to all of the arguments and overrides whatever setting the arguments have, and the individual arguments' hide_possible_values is already correctly handled

@epage
Copy link
Member

epage commented Sep 27, 2022

Thanks for the reminder!

@epage epage merged commit eed6aec into clap-rs:master Sep 27, 2022
@epage
Copy link
Member

epage commented Sep 27, 2022

This was done in master which corresponds with v4. If you want, you can cherry-pick this into the v3-master branch.

@tahmid-23 tahmid-23 deleted the mangen-hide-fix branch September 27, 2022 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

clap_man should respect the various Hide attributes
2 participants