-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduced the editor quick actions toolbar #130
Conversation
…a, toggle editor read-only, and destroy editor.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
I briefly scanned the CKEditor 5 Inspector code (as this was the first time I saw it), then I ran this PR and it works as expected.
The only one thing to consider is updating the screenshot of the Inspector in the docs after releasing new version: https://ckeditor.com/docs/ckeditor5/latest/framework/guides/development-tools.html#ckeditor-5-inspector. I don't know if it appears elsewhere in the docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is how decoupled document editor works. The integrator takes care of injecting the toolbar and removing it. It's just a sample so I didn't bother. |
README.md of the inspector on Github/Npm, that's for sure. |
I extracted updating documentation to a new issue – #133. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Feature: Introduced editor quick actions toolbar (see #38) to log editor data, toggle editor read-only, and destroy editor. Closes #121. Closes #104.
Notes
Under the hood,
Button
component to be more versatile because the number of buttons increased and some needisOn/isEnabled
states.