Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: recommend ccc #740

Merged
merged 2 commits into from
Sep 10, 2024
Merged

chore: recommend ccc #740

merged 2 commits into from
Sep 10, 2024

Conversation

homura
Copy link
Collaborator

@homura homura commented Sep 10, 2024

Resolve #739

Copy link

vercel bot commented Sep 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
lumos-website ✅ Ready (Inspect) Visit Preview Sep 10, 2024 9:53am

Copy link

codecov bot commented Sep 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.05%. Comparing base (321ae50) to head (3333e5e).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #740      +/-   ##
===========================================
+ Coverage    87.04%   87.05%   +0.01%     
===========================================
  Files          132      132              
  Lines        24785    24785              
  Branches      2690     2691       +1     
===========================================
+ Hits         21573    21577       +4     
+ Misses        3171     3169       -2     
+ Partials        41       39       -2     

see 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 321ae50...3333e5e. Read the comment docs.

@Keith-CY
Copy link
Member

Is this ready to merge?

@homura
Copy link
Collaborator Author

homura commented Sep 10, 2024

Is this ready to merge?

yes, waiting for approval

@Keith-CY Keith-CY merged commit c0d4ea7 into develop Sep 10, 2024
9 checks passed
@Keith-CY Keith-CY deleted the ccc branch September 10, 2024 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lead users to ckb-ecofund/ccc
2 participants