-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: support for CKB2023 #527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- lumos dependencies and modules are really a bit much - contributors often depend on yarn's auto-hoist to cause some module to not be installed correctlly
the docker is no longer needed
# Conflicts: # packages/ckb-indexer/package.json # packages/common-scripts/package.json # packages/debugger/package.json # packages/e2e-test/package.json # packages/experiment-tx-assembler/package.json # packages/hd-cache/package.json # packages/helpers/package.json # packages/transaction-manager/package.json
5 tasks
zhangyouxin
approved these changes
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #525
This PR is to support CKB2023, it will be released to
[email protected]
threshold
field in theConsensus
changed fromnumber
toHexString
BREAKING: thehardfork_features
field in theConsensus
changed fromArray
to anObject
only_committed
of theget_transaction
data2
hash typereason
toTxStatus
getBlock
&getBlockNumber
with the new verbosity andwithCycles
getHeader
&getHeaderByNumber
with the new verbosityWe also plan to
yarn 1.x
topnpm
to avoid the phantom dependencies and to save the disk spaceType of change
Please delete options that are not relevant.
When to Release
After the [email protected] is active on testnet, Lumos will release a 0.21.0 to support the CKB2023, if you want to experience CKB 2023, please install via
npm install @ckb-lumos/[module-name]@ckb2023