fix: remove 0x prefix of normalize hex number

ckb-js · Oct 13, 2023 · fe92d3e · fe92d3e
1 parent bc0519a
commit fe92d3e
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 3 deletions.
diff --git a/packages/toolkit/src/normalizers.js b/packages/toolkit/src/normalizers.js
@@ -18,7 +18,7 @@ import { Reader } from "./reader";
 function normalizeHexNumber(length) {
   return function (debugPath, value) {
     if (!(value instanceof ArrayBuffer)) {
-      let intValue = BI.from(value).toHexString();
+      let intValue = BI.from(value).toHexString().substring(2);
       if (intValue.length % 2 !== 0) {
         intValue = "0" + intValue;
       }

diff --git a/packages/toolkit/tests/normailizers.js b/packages/toolkit/tests/normailizers.js
@@ -2,9 +2,31 @@ const test = require("ava");
 const { normalizers } = require("../lib");
 
 test("correct outPoint should pass validation", (t) => {
-  normalizers.NormalizeOutPoint({
+  const normalizedOutpoint = normalizers.NormalizeOutPoint({
     txHash: `0x${"00".repeat(32)}`,
     index: "0x1",
   });
-  t.pass();
+  const expectedNormalizedIndex = new ArrayBuffer(4);
+  const view = new Int32Array(expectedNormalizedIndex);
+  view[0] = 1;
+
+  t.deepEqual(normalizedOutpoint, {
+    index: expectedNormalizedIndex,
+    txHash: new ArrayBuffer(32),
+  });
+});
+
+test("error outPoint should not pass validation", (t) => {
+  t.throws(() => {
+    normalizers.NormalizeOutPoint({
+      txHash: `0x${"00".repeat(32)}`,
+      index: "0x",
+    });
+  });
+  t.throws(() => {
+    normalizers.NormalizeOutPoint({
+      txHash: `0x${"00".repeat(32)}`,
+      index: "not a number",
+    });
+  });
 });