Change the unit of the duration of a volunteer opportunity #559
Conversation
|
I think this would need an upgrade step for existing systems. I believe this is a legacy rooted in how activities represent time, but I'd have to dig for what the precedent actually was. I do know that the position has been that this is best handled by formatting in displays. |
|
@ginkgomzd I agree this was based on how we always show activity duration in minutes. But this PR is just a display improvement where we show the volunteer time in hours ( since it could be cumbersome to convert to minutes when you are logging 5/6 hours). I don't think any changes to the upgrade are warranted as it shouldn't affect how data is stored. |
|
ah, I didn't look carefully at what you were doing here. Did you try to break it entering fractional hours? I'll give this a proper look this week or next. Cheers |
|
@ginkgomzd what do you think about this? Can you please take a look at this PR? Thanks! |
Change the unit of the duration of a volunteer opportunity