WIP: Vol 16 log own hours #445
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tes don't have to be specified inline.
…' templates don't have to be specified inline." Whoops, didn't need this code. I forgot about CiviCRM's custom loader with the ~ prefix (https://github.com/civicrm/civicrm-core/blob/e3d90d6c78a6ce1368e6c7225b5312d63718c06a/js/angular-crmResource/all.js#L75). This reverts commit 508181d.
…d volunteer project thumbs as well as a filter for stripping HTML tags.
…ct is updated, due to stale address part count.
…n-readable state names.
… the flexible need ID and the current contact ID to satisfy the API's field requirements.
…hether there are existing activities. Modify help text accordingly.
…s on focusout. It appears there are some expectations that the element have a proper form (vs. an ng-form) as a parent.
…t" button is disabled for Step 2 until a project selection has been made.
… contact ID. Now users will only be able to see/edit time entries pertaining to their own volunteer activities.
…e volunteer role is displayed.
…for your changes. Lines starting
…time access to necessary APIs.
…eers logging time.
…time access to necessary Activity APIs.
…d of hardcoding the date format.
Replaced links with buttons. Forced route reload for "Log More Hours" option.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
W.I.P. DO NOT MERGE.
I'm not aware of what the barriers to merging. I just want an easy way to track this feature branch.