Issue #180: Process the install.sql in Smarty to support installation on multi-lingual. #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…llation on multi-lingual.
|
Do I understand correctly, that this patchset will allow for installation on civi installs where the multilingual table conversion took place? |
|
@lynxlynxlynx: It hasn't been tested -- at least not by me. In a separate conversation, @mlutfy and I discussed changing the install script to use the API for creating option values instead of coding the same in SQL. I believe we agreed this was a better approach for everyone, but these changes haven't been implemented yet. |
|
Aha. I'm in a situation like that and the install failed, so I was trying to determine if it was the same issue. I'll need to retry with debugging on, since the default error messages are useless. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You probably don't want to merge this, because introduces lots of complexity just for an OptionValue :)