Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev/core#5640 explicitly disable mod_negotiation MultiViews in default Standalone apache config #31727

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ufundo
Copy link
Contributor

@ufundo ufundo commented Jan 8, 2025

Overview

mod_negotiation MultiViews seems liable to cause problems if it is enabled. Let's explicitly disable it.

Before

After

  • if mod_negotiation is enabled, MultiViews is explicitly disabled

Technical Details

I'm not sure if there are any times this could cause problems. Maybe if a host's apache config forces you to enable this option it will crash - but it is probably better to crash earlier than go through the install process to get a seemingly working site, then be unable to log in.

I found that this the default Laravel .htaccess has similar: https://github.com/laravel/laravel/blob/658a49a19e98a6059a543be7564d39dc2e6970e0/public/.htaccess#L3 ( Here Options -Indexes is also inside the IfModule conditional ? Maybe we should do that too? )

Copy link

civibot bot commented Jan 8, 2025

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...
  • If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
  • A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
  • A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
  • If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
  • Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
  • A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
  • To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
  • For more information about contributing, see CONTRIBUTING.md.
Quick links for reviewers...

➡️ Online demo of this PR 🔗

@civibot civibot bot added the master label Jan 8, 2025
Copy link

civibot bot commented Jan 8, 2025

The issue associated with the Pull Request can be viewed at https://lab.civicrm.org/dev/core/-/issues/5640

@ufundo ufundo force-pushed the disable-multiviews branch from 5de208b to 3e8537f Compare January 8, 2025 10:32
@ufundo ufundo marked this pull request as ready for review January 8, 2025 10:32
@ufundo ufundo added the run-standalone Civibot should setup demos+tests for Standalone label Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
master run-standalone Civibot should setup demos+tests for Standalone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant