Angular - Noisily deprecate 'settings' in favor of 'settingsFactory'

[colemanw]

Overview

This more aggressively deprecates something that's been deprecated since 2020, to warn developers that they really need to stop using it.

See:

• [REF] Cleanup Ang modules in core to follow conventions #19052
• Afform - improve loading performance #27783

Technical Details

Once #27783 switches over to use caching the settings will be cached and no longer dynamic, potentially producing weird bugs. Core hasn't used this pattern in 3 years, and only a handful of extensions in universe still do. I'm submitting PRs/issues to them:

Comments

Extension PRs/issues submitted:

• Angular - Switch to settingsFactory veda-consulting-company/uk.co.vedaconsulting.mosaico#617
• https://lab.civicrm.org/extensions/areas/-/merge_requests/8
• https://lab.civicrm.org/extensions/timetrack/-/merge_requests/1
• https://lab.civicrm.org/extensions/form-processor/-/merge_requests/64
• Fix deprecated 'settings' in .ang.php files compucorp/uk.co.compucorp.civicase#985

[civibot]

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...

• If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
• A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
• A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
• If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
• Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
• A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
• To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
• For more information about contributing, see CONTRIBUTING.md.

Quick links for reviewers...

• ➡️ PR Demo site (can be rebuilt with the command test this please).
• 📖 Review standards
• 🗒️ Review template (brief or verbose)

➡️ Online demo of this PR 🔗

[colemanw]

@totten this adds both a noisy deprecation notice and a status check... and is passing!

[agileware-justin]

Would be cool if the "Online demo of this PR" included those other patched extensions.

[colemanw]

@agileware-justin all core-bundled extensions already pass the check (and have done-so for years) so this is just about bringing 3rd-party extensions up to compliance.