[REF] [Import] Remove last in-between parser class #23227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
eileenmcnaughton
force-pushed
the
inbetween_4
branch
from
0b67fb1 to
5c2a8da
Compare
eileenmcnaughton
added a commit
to eileenmcnaughton/civihr
that referenced
this pull request
Apr 15, 2022
Unlike the others this does have non-core refs in civihr & csvimport - I suspect these are copy & paste rather than functional but will patch
eileenmcnaughton
force-pushed
the
inbetween_4
branch
from
5c2a8da to
d60cd66
Compare
eileenmcnaughton
added a commit
to eileenmcnaughton/nz.co.fuzion.csvimport
that referenced
this pull request
Apr 15, 2022
|
test this please |
eileenmcnaughton
changed the title
|
Merging, it's the same cleanup as the others. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Remove last in-between parser class
Before
CRM_Event_Import_Parser_Participant extends CRM_Event_Import_ParserAfter
Functionality moved over - directly extends parent
class CRM_Event_Import_Parser_Participant extends CRM_Import_ParserTechnical Details
Unlike the others this does have non-core refs in civihr & csvimport -
I suspect these are copy & paste rather than functional but will patch
Comments
compucorp/civihr#2993
eileenmcnaughton/nz.co.fuzion.csvimport@8071811