Merge pull request #73 from citysciencelab/remove-gravatar

feat: remove gravatar url

src/ump/api/keycloak_utils.py

@@ -1,6 +1,5 @@
 """Keycloak helper functions"""
 
-import hashlib
 from os import environ as env
 
 from keycloak import KeycloakAdmin, KeycloakOpenIDConnection
@@ -28,14 +27,7 @@ def find_user_id_by_email(email):
     return None
 
 
-def get_user_name(user_id):
-    """Retrieve the username by user id"""
+def get_user_details(user_id):
+    """Retrieve the user details by user id"""
     user = keycloak_admin.get_user(user_id)
-    return user["username"] if user else None
-
-
-def get_gravatar_url(user_id):
-    """Retrieve the gravatar url by user id"""
-    email = keycloak_admin.get_user(user_id)["email"].strip().lower()
-    hash_email = hashlib.md5(email.encode("utf-8")).hexdigest()
-    return f"https://www.gravatar.com/avatar/{hash_email}"
+    return user

src/ump/api/routes/users.py

@@ -5,7 +5,7 @@
 from apiflask import APIBlueprint
 from flask import Response, g
 
-from ump.api.keycloak_utils import get_gravatar_url, get_user_name
+from ump.api.keycloak_utils import get_user_details
 
 users = APIBlueprint("users", __name__)
 
@@ -17,13 +17,14 @@ def index(user_id=None):
     if auth is None:
         return Response(mimetype="application/json", status=401)
 
-    user_name = get_user_name(user_id)
-    gravatar_url = get_gravatar_url(user_id)
+    details = get_user_details(user_id)
 
     response_data = {
         "user_id": user_id,
-        "username": user_name,
-        "gravatar_url": gravatar_url,
+        "username": details['username'],
+        "firstName": details['firstName'],
+        "lastName": details['lastName'],
+        "email": details['email'],
     }
 
     return Response(json.dumps(response_data), mimetype="application/json")