Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add json array order configuration option in java #1254

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

novarx
Copy link

@novarx novarx commented Nov 6, 2024

No description provided.

Copy link
Collaborator

@bbortt bbortt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one note on the tests.

@@ -258,6 +250,64 @@ public static JsonAssertion[] validOnlyWithIgnoreExpressions() {
).toArray(new JsonAssertion[0]);
}

@Test
void validate_shouldCheckArrayOrder_whenPropertyTrue() {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these must be public or they won't be executed.

@bbortt
Copy link
Collaborator

bbortt commented Dec 9, 2024

I think this is obsolete @novarx @tschlat

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants