Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove duplicate database schema entries #269

Merged
merged 4 commits into from
May 9, 2024

Conversation

bbortt
Copy link
Collaborator

@bbortt bbortt commented May 7, 2024

tldr; database normalizations.

  • removed the duplicate error messages on scenario_execution and test_result
    • now only being present in test_result
  • removed the duplicate status report on scenario_execution and test_result
    • now only being present in test_result
  • information is still available, because of the new relationship of scenario_execution to test_result
  • error information has been splitted into stacktrace and error_message (the later containing only the root cause message)
    • both fields are blobs; no more length restriction

see the updated documentation / database schema.

@bbortt bbortt added IN PROGRESS Type: Maintenance TO REVIEW Prio: High java Pull requests that update Java code javascript Pull requests that update Javascript code labels May 7, 2024
@bbortt bbortt self-assigned this May 7, 2024
@bbortt bbortt force-pushed the fix/some-bugs branch 3 times, most recently from ffa8c29 to cb435e4 Compare May 8, 2024 06:05
@bbortt bbortt changed the title Draft: remove duplicate database schema entries remove duplicate database schema entries May 8, 2024
@bbortt
Copy link
Collaborator Author

bbortt commented May 8, 2024

there is one more thing I would like to take a look at:

  • duplicate getters in criteria api

@bbortt bbortt merged commit a6c3d89 into citrusframework:main May 9, 2024
7 checks passed
@bbortt bbortt deleted the fix/some-bugs branch May 9, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IN PROGRESS java Pull requests that update Java code javascript Pull requests that update Javascript code Prio: High TO REVIEW Type: Maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants