citrus 4 0 release

[bbortt]

No description provided.

[bbortt]

did someone of you @christophd / @tschlat change something regarding XML / java property loading? the inbound dictionary did load this before the citrus 4.0.0 release (e.g. milestone 2):

now it contains this:

talking about the failing sample-swdl... I wonder how the changes could affect the java properties loading.

[bbortt]

ok, I've tracked it down to the AbstractDataDictionary:

index a5952919a..88cd18db8 100644
--- a/core/citrus-base/src/main/java/org/citrusframework/variable/dictionary/AbstractDataDictionary.java
+++ b/core/citrus-base/src/main/java/org/citrusframework/variable/dictionary/AbstractDataDictionary.java
@@ -73,14 +73,17 @@ public abstract class AbstractDataDictionary<T> extends AbstractMessageProcessor
     @Override
     public void initialize() {
         if (mappingFile != null) {
-
             if (logger.isDebugEnabled()) {
                 logger.debug("Reading data dictionary mapping " + mappingFile.getLocation());
             }

             Properties props = new Properties();
             try (InputStream inputStream = mappingFile.getInputStream()) {
-                props.load(inputStream);
+                if (mappingFile.getFile().getName().endsWith(".xml")) {
+                    props.loadFromXML(inputStream);
+                } else {
+                    props.load(inputStream);
+                }
             } catch (IOException e) {
                 throw new CitrusRuntimeException(e);
             }

@christophd either we need a citrus release 4.0.1 (and then I am questioning if (mappingFile.getFile().getName().endsWith(".xml")) {, that would probably go better?) or we drop the mapping-as-xml-file feature.. what do you think?

Edit: I would discourage from dropping the mapping-as-xml-file support, because the property in the simulator is named citrus.simulator.inboundXmlDictionary and citrus.simulator.outboundXmlDictionary what implicitly tells the user that it is an XML mapping-as-xml-file.