Document various natives #938
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added purpose, parameter names and real names of natives in the following namespaces: CAM, HUD, NETWORK
Add missing parenthesis to GetPauseMenuPosition
Added parameter information and used correct names for speed parameters
Fixed underscore in alias name and added description.
PsychoShock
suggested changes
Dec 26, 2023
There was a problem hiding this comment.
I left some review. I recommand you change them before @4mmonium see them. Also this is a BIG BIG PR, you should maybe to 8-10 files max per PR.
- If the changes involve removing files, I'd rather see 8 changes max per PR between removals and file adds (this happens when a native is renamed to something else).
- If cs_type changes are required, same.
- If it's just description/parameter name changes then I guess more than 10 up to a limit of 15 are fine.
hi, i've taken a look at your reviews and changed the files accordingly, let me know if there's anything else i missed. and also sorry for the huge pr |
4mmonium
reviewed
Dec 26, 2023
4mmonium
reviewed
Dec 26, 2023
Changed hashes to look better for the markdown
PsychoShock
suggested changes
Dec 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added purpose, parameter names and real names of natives that I've used in the past, in the following namespaces: CAM, HUD, NETWORK