Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Update natives and modify description for natives #937

Merged
merged 1 commit into from
Jun 14, 2024
Merged

feat: Update natives and modify description for natives #937

merged 1 commit into from
Jun 14, 2024

Conversation

spacevx
Copy link
Contributor

@spacevx spacevx commented Nov 27, 2023 •
edited
Loading

  1. N_0x32f34ff7f617643b:

    • Updated the native N_0x32f34ff7f617643b.
    • Added a description to explain the purpose of this native. (source: FiveM Scripters Discord)

  2. GetLabelText:

    • Made updates to GetLabelText natives.
    • Updated the description and examples for the GetLabelText native.

  3. TaskWarpPedIntoVehicle:

    • Updated the description and examples for the TaskWarpPedIntoVehicle native.

  4. _SET_UNK_FLOAT_0x104_FOR_SUBMARINE_VEHICLE_TASK:

    • Updated the description and examples for the _SET_UNK_FLOAT_0x104_FOR_SUBMARINE_VEHICLE_TASK native.

  5. _SET_UNK_BOOL_0x102_FOR_SUBMARINE_VEHICLE_TASK:

    • Updated the description and examples for the _SET_UNK_BOOL_0x102_FOR_SUBMARINE_VEHICLE_TASK native.

Superseed #864

@spacevx
Copy link
Contributor Author

spacevx commented Nov 27, 2023

For the native N_0x32f34ff7f617643b, credit goes to @Local9 on the FiveM Scripters Discord for discovering how to use this native. While I believe it may have applications in other scenarios, my knowledge of scaleforms is limited, and I haven't explored how to use it in different cases.

@spacevx spacevx force-pushed the u3 branch 2 times, most recently from 953e3ca to 9f84ee6 Compare November 27, 2023 23:28
@spacevx spacevx changed the title feat: Update 2 natives and modify description for one native feat: Update natives and modify description for natives Nov 27, 2023
4mmonium
4mmonium suggested changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@4mmonium 4mmonium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there, a couple changes needed. I will test the examples soon. Thank you!

GRAPHICS/SetScaleformMovieToUseLargeRt.md Outdated Show resolved Hide resolved
HUD/GetFilenameForAudioConversation.md Show resolved Hide resolved
VEHICLE/SetTransformRateForAnimation.md Outdated Show resolved Hide resolved
VEHICLE/SetTransformToSubmarineUsesAlternateInput.md Outdated Show resolved Hide resolved
@spacevx
Copy link
Contributor Author

spacevx commented Nov 28, 2023

Hey should be good

@spacevx spacevx requested a review from 4mmonium November 28, 2023 18:32
@spacevx
Copy link
Contributor Author

spacevx commented Dec 25, 2023 •
edited
Loading

Hey @4mmonium, I'm bumping this to make sure you're not forgetting about this PR sir

PsychoShock
PsychoShock approved these changes Jan 20, 2024
View reviewed changes
Copy link
Contributor

@PsychoShock PsychoShock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a cool PR, great job :)

Make sure to squash it to make it cleaner.

GRAPHICS/SetScaleformMovieToUseLargeRt.md Outdated Show resolved Hide resolved
VEHICLE/SetTransformToSubmarineUsesAlternateInput.md Show resolved Hide resolved
@spacevx
feat: Update natives and modify description for natives
ff03676 
* feat: Update natives and modify description for natives
* Correct parameter typo and add missing examples header.
@spacevx
Copy link
Contributor Author

spacevx commented Jan 27, 2024

Should be good right now

@spacevx
Copy link
Contributor Author

spacevx commented Jan 30, 2024

Any news @4mmonium ?

@PsychoShock
Copy link
Contributor

No need to ping anyone. They will review it when they will have time. Thanks.

@spacevx
Copy link
Contributor Author

spacevx commented May 2, 2024

Sorry to re-ping you, @4mmonium, but do you have any news on this PR? It looks like this PR was lost among others

@spacevx spacevx closed this May 13, 2024
@4mmonium 4mmonium reopened this Jun 14, 2024
4mmonium
4mmonium approved these changes Jun 14, 2024
View reviewed changes
Copy link
Contributor

@4mmonium 4mmonium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, merging, thanks!

@4mmonium 4mmonium merged commit 011c571 into citizenfx:master Jun 14, 2024
2 checks passed
This was referenced Aug 7, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PsychoShock PsychoShock PsychoShock approved these changes

@4mmonium 4mmonium 4mmonium approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@spacevx @PsychoShock @4mmonium