Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore dead Imgur links #1056

Closed
wants to merge 1 commit into from
Closed

Conversation

ItsJunction
Copy link
Contributor

Many Imgur images were deleted at some point within the last year, this PR restores a fair few of them. Please let me know if I'm missing any not listed below.

Note this PR does NOT restore any dead links found in "unmodern" docs.

The following links I could not find anything for:

Many imgur links were deleted at some point within the last year, this PR restores a fair few of them. Please let me know if I'm missing any not listed below.

Note this PR does NOT restore any dead links found in "unmodern" docs.

 The following links I could not find anything for:
- https://i.imgur.com/qLbXWcQ.png in AddBlipForArea.md
- https://i.imgur.com/0j7O7Rh.png in AddBlipForArea.md
- https://i.imgur.com/hS6ki7p.png in SetRadiusBlipEdge.md
@AvarianKnight
Copy link
Collaborator

With imgur starting to block/delete more images it might be worth putting these images on the forums and use the image link from the forums

@PsychoShock
Copy link
Contributor

Hello,

I've noticed that uploading images directly from users might not be the most efficient way to handle visuals. Like Avarian said, with Imgur blocking images on CFX wouldn't be a good idea. To streamline the process and ensure clarity in the documentation, implementing a new section specifically for game documents might be a good idea. From now on, all images related to game documentation could be uploaded to the designated section directly.

To facilitate this transition, you can update the contribution.md file. Contributors would be encouraged to refer to this file for guidelines on uploading images. By consolidating all visual elements in one place, it will be easier for anyone to replace / update them.

Thanks

@ook3D
Copy link
Contributor

ook3D commented Mar 12, 2024

some additional options for image hosting could be an official CFX one, or use other options such as https://imgbb.com/ :)

@4mmonium
Copy link
Contributor

While I cannot really comment on this right now, I think hosting the images on external sources won't stop these issues from happening and will cause more PRs to be opened where new links are provided to resolve '404' URLs.

Ideally, hosting this somewhere internally might be a better idea, but it's not something I can comment on at the moment. Will provide feedback once I have it 🙂

@AvarianKnight
Copy link
Collaborator

AvarianKnight commented Mar 15, 2024

Ideally, hosting this somewhere internally might be a better idea, but it's not something I can comment on at the moment. Will provide feedback once I have it 🙂

It would be possible to just have an unlisted thread on the forums used for image uploads on native docs

EDIT: Just realized I already said this earlier whoopsie

@VIRUXE
Copy link

VIRUXE commented May 30, 2024

@PsychoShock pointed me to this PR, from the issue I created about the docs, which solves, in part, this "imgur" issue, for the native reference.

I'll pick up on this on another PR but with images uploaded from GitHub's web interface, where images get uploaded to their cdn.

@AvarianKnight
Copy link
Collaborator

This isn't a valid solution, as has been previously said.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants